linux-kernel - [tip:efi/core] efi: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jan 2018 08:19:58 -0800
From:   tip-bot for Vasyl Gomonovych <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     gomonovych@...il.com, tglx@...utronix.de, peterz@...radead.org,
        hpa@...or.com, ard.biesheuvel@...aro.org,
        linux-kernel@...r.kernel.org, tbaicar@...eaurora.org,
        arvind.yadav.cs@...il.com, matt@...eblueprint.co.uk,
        sboyd@...eaurora.org, torvalds@...ux-foundation.org,
        mingo@...nel.org
Subject: [tip:efi/core] efi: Use PTR_ERR_OR_ZERO()

Commit-ID:  50342b2e498777df237a40a23eebc02f0935e636
Gitweb:     https://git.kernel.org/tip/50342b2e498777df237a40a23eebc02f0935e636
Author:     Vasyl Gomonovych <gomonovych@...il.com>
AuthorDate: Tue, 2 Jan 2018 18:10:40 +0000
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 3 Jan 2018 14:03:48 +0100

efi: Use PTR_ERR_OR_ZERO()

Fix ptr_ret.cocci warnings:

  drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
Signed-off-by: Matt Fleming <matt@...eblueprint.co.uk>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Arvind Yadav <arvind.yadav.cs@...il.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Stephen Boyd <sboyd@...eaurora.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Tyler Baicar <tbaicar@...eaurora.org>
Cc: linux-efi@...r.kernel.org
Link: http://lkml.kernel.org/r/20180102181042.19074-4-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/firmware/efi/efi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 557a478..8ce70c2 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -608,7 +608,7 @@ static int __init efi_load_efivars(void)
 		return 0;
 
 	pdev = platform_device_register_simple("efivars", 0, NULL, 0);
-	return IS_ERR(pdev) ? PTR_ERR(pdev) : 0;
+	return PTR_ERR_OR_ZERO(pdev);
 }
 device_initcall(efi_load_efivars);
 #endif