linux-kernel - Re: [RESEND PATCH v2 11/15] ASoC: qcom: qdsp6: Add support to q6afe dai driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4edcacb6-6567-8f1a-dd71-cbcce0a66e06@linaro.org>
Date:   Wed, 3 Jan 2018 16:27:12 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Mark Brown <broonie@...nel.org>, linux-arm-msm@...r.kernel.org,
        alsa-devel@...a-project.org, David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Patrick Lai <plai@...eaurora.org>,
        Banajit Goswami <bgoswami@...eaurora.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, sboyd@...eaurora.org
Subject: Re: [RESEND PATCH v2 11/15] ASoC: qcom: qdsp6: Add support to q6afe
 dai driver



On 02/01/18 23:28, Bjorn Andersson wrote:
> On Thu 14 Dec 09:33 PST 2017, srinivas.kandagatla@...aro.org wrote:
> 
>> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>>
>> This patch adds support to q6afe backend dais driver.
>>
> 
> Isn't the list of backend DAIs platform-dependent?

dai links and connections between backend and front ends are platform 
dependent.

> 
> [..]
>> +static const struct snd_soc_dapm_widget hdmi_dapm_widgets[] = {
>> +	SND_SOC_DAPM_AIF_OUT("HDMI", "HDMI Playback", 0, 0, 0, 0),
>> +	SND_SOC_DAPM_OUTPUT("HDMI-RX"),
>> +};
>> +
>> +static const struct snd_soc_component_driver msm_dai_hdmi_q6_component = {
> 
> How will this look beyond HDMI? I'm having issues mapping this to
> downstream.

ex:
For slimbus dais, we would have more entries of "struct 
snd_soc_dai_driver" in this file.

Basically these are the dais that are exposed by the dsp firmware.

Depending on the actually platform some of these dais would be setup 
accordingly.


> 
>> +	.name		= "msm-dai-q6-hdmi",
>> +	.dapm_widgets = hdmi_dapm_widgets,
>> +	.num_dapm_widgets = ARRAY_SIZE(hdmi_dapm_widgets),
>> +	.controls = hdmi_config_controls,
>> +	.num_controls = ARRAY_SIZE(hdmi_config_controls),
>> +	.dapm_routes = hdmi_dapm_routes,
>> +	.num_dapm_routes = ARRAY_SIZE(hdmi_dapm_routes),
>> +};
>> +
> 
> Regards,
> Bjorn
>