linux-kernel - Re: [PATCH] ASoC: max98373: Added Amplifier Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Jan 2018 16:57:42 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     Ryan Lee <RyanS.Lee@...imintegrated.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>, "arnd@...db.de" <arnd@...db.de>,
        "afd@...com" <afd@...com>,
        "robert.jarzmik@...e.fr" <robert.jarzmik@...e.fr>,
        "supercraig0719@...il.com" <supercraig0719@...il.com>,
        "jbrunet@...libre.com" <jbrunet@...libre.com>,
        "dannenberg@...com" <dannenberg@...com>,
        "romain.perier@...labora.com" <romain.perier@...labora.com>,
        "bryce.ferguson@...kwellcollins.com" 
        <bryce.ferguson@...kwellcollins.com>,
        "m-stecklein@...com" <m-stecklein@...com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ryan.lee.maxim@...il.com" <ryan.lee.maxim@...il.com>
Subject: Re: [PATCH] ASoC: max98373: Added Amplifier Driver

On Mon, Dec 25, 2017 at 11:17:29PM +0000, Kuninori Morimoto wrote:

> Having private regmap seems a little bit duplicate for me,
> because we can get it from component or dev.
> But sometimes, in some drivers, it seems can be difficult.
> Sorry for my noise.

It is duplication but if you've only got the dev then it makes things a
bit faster as the call to look up a regmap from a dev is relatively
expensive.  That's not the case for components though where it's just a
straight variable lookup so it's more a case of how clean the code looks
and preference there.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)