linux-kernel - Re: [PATCH v2 9/9] ASoC: Intel: kconfig: add some comments for if symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1514999270.7000.595.camel@linux.intel.com>
Date:   Wed, 03 Jan 2018 19:07:50 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        alsa-devel@...a-project.org
Cc:     tiwai@...e.de, broonie@...nel.org, torvalds@...ux-foundation.org,
        vinod.koul@...el.com, liam.r.girdwood@...ux.intel.com,
        arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 9/9] ASoC: Intel: kconfig: add some comments for if
 symbols

On Wed, 2018-01-03 at 10:50 -0600, Pierre-Louis Bossart wrote:
> From: Vinod Koul <vinod.koul@...el.com>
> 
> Helps in finding if endings

Seems some (all?) comments not been addressed.
See below.
 
>  config SND_SOC_INTEL_BAYTRAIL
> -	tristate "Intel ASoC SST driver for Baytrail (legacy)"
> +	tristate "Baytrail (legacy) Platforms"
>  	depends on DMADEVICES && ACPI
>  	select SND_SOC_INTEL_SST
>  	select SND_SOC_INTEL_SST_ACPI
> @@ -73,7 +73,7 @@ config SND_SOC_INTEL_BAYTRAIL
>  	  not recommended, use SND_SST_ATOM_HIFI2_PLATFORM instead.
>  
>  config SND_SST_ATOM_HIFI2_PLATFORM_PCI
> -	tristate "Intel ASoC SST driver for PCI HiFi2 platforms
> (Medfield, Merrifield)"
> +	tristate "PCI HiFi2 platforms (Medfield, Merrifield)
> platforms"

platforms ... platforms.

Moreover, perhaps use above pattern "... Platforms" ?

>  	depends on X86 && PCI
>  	select SND_SST_IPC_PCI
>  	select SND_SOC_COMPRESS
> @@ -87,7 +87,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
>  	  is not in the standard firmware tree
>  
>  config SND_SST_ATOM_HIFI2_PLATFORM
> -	tristate "Intel ASoC SST driver for ACPI HiFi2 platforms
> (Baytrail, Cherrytrail)"
> +	tristate "ACPI HiFi2 platforms (Baytrail, Cherrytrail)
> Platforms"

Ditto.
 
>  config SND_MFLD_MACHINE
> -	tristate "SOC Machine Audio driver for Intel Medfield MID
> platform"
> +	tristate "Intel Medfield MID"

Perhaps "Medfield (Intel MID)" ?

At least it looks to me more consistent with the rest.

>  config SND_SOC_INTEL_HASWELL_MACH
> -	tristate "ASoC Audio DSP support for Intel Haswell Lynxpoint"
> +	tristate "Haswell Lynxpoint"
>  	depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM
>  	select SND_SOC_RT5640
>  	help

>  config SND_SOC_INTEL_BROADWELL_MACH
> -	tristate "ASoC Audio DSP support for Intel Broadwell
> Wildcatpoint"
> +	tristate "Intel Broadwell Wildcatpoint"

Drop Intel.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy