linux-kernel - Re: [PATCH v2 2/4] remoteproc: Rename "load_rsc_table" to "parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180103201940.GI12655@minitux>
Date:   Wed, 3 Jan 2018 12:19:40 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Loic PALLARDY <loic.pallardy@...com>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>,
        "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-soc@...r.kernel.org" <linux-soc@...r.kernel.org>,
        Suman Anna <s-anna@...com>,
        Avaneesh Kumar Dwivedi <akdwived@...eaurora.org>
Subject: Re: [PATCH v2 2/4] remoteproc: Rename "load_rsc_table" to "parse_fw"

On Wed 03 Jan 05:15 PST 2018, Loic PALLARDY wrote:
> > -----Original Message-----
> > From: linux-remoteproc-owner@...r.kernel.org [mailto:linux-remoteproc-
> > owner@...r.kernel.org] On Behalf Of Loic PALLARDY
> > Sent: Wednesday, January 03, 2018 11:27 AM
> > To: Bjorn Andersson <bjorn.andersson@...aro.org>; Ohad Ben-Cohen
> > <ohad@...ery.com>
> > Cc: linux-remoteproc@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> > arm-msm@...r.kernel.org; linux-soc@...r.kernel.org; Suman Anna <s-
> > anna@...com>; Avaneesh Kumar Dwivedi <akdwived@...eaurora.org>
> > Subject: RE: [PATCH v2 2/4] remoteproc: Rename "load_rsc_table" to
> > "parse_fw"
> > > -----Original Message-----
> > > From: linux-remoteproc-owner@...r.kernel.org [mailto:linux-
> > remoteproc-
> > > owner@...r.kernel.org] On Behalf Of Bjorn Andersson
[..]
> > > -	/* load resource table */
> > > -	ret = rproc_load_rsc_table(rproc, fw);
> > > +	/* parse firmware resources */
> > > +	ret = rproc_parse_fw(rproc, fw);
> > Hi Bjorn,
> > 
> > I think it will be good to keep resource (aka rsc) in function name. only
> > "parse_fw" is not enough explicit and we don't know why rproc should parse
> > firmware.
> > 
> > Regards,
> > Loic
> Forgot my previous remark, better understanding thanks to the rest of
> the series.
> Anyway, will be nice to have a comment here as it is not only parsing
> the firmware, you collect some information like copy of the resource
> table, list of elf segment to dump...
> I think it is important to be clear about resource table management as
> it is a key element of the remoteproc core, where it is loaded, where
> it is copied back in memory...

I didn't manage to come up with a better name, but adding a comment to
capture this makes a lot of sense. I will respin this patch!

Thanks for reviewing this!

Regards,
Bjorn