linux-kernel - Re: dma_async_device_unregister called while 2 clients hold a reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180103035106.GD18649@localhost>
Date:   Wed, 3 Jan 2018 09:21:06 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
Cc:     dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: dma_async_device_unregister called while 2 clients hold a
 reference

On Tue, Dec 26, 2017 at 10:37:13AM +0530, Rayagonda Kokatanur wrote:
> Hi All,
> 
> I am getting following error when I unload one of my dma client driver.
> When I looked further into dmaengine.c file I found that the error is
> because of WARN_ONCE in dma_async_device_unregister() api.
> 
> Is this error expected ?
> Why do we need that WARN_ONCE macro ? If I comment that, errors will vanish.
> Do I need to set anything in client driver before calling
> dma_async_device_unregister() api ?
> 
> 
> root@...958802a8021:~# rmmod bcm_sba_raid
> [ 357.891751] dma_async_device_unregister called while 2 clients hold a
> reference

that means you are trying to remove the module while two clients hold the
ref. You should first ensure the clients are unloaded and then your driver

IMO this is a valid warn.

-- 
~Vinod