linux-kernel - Re: [PATCH 10/11] retpoline/taint: Taint kernel for missing retpoline in compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a0ba49a-14de-bd67-4446-41ab2d47cd5f@infradead.org>
Date:   Wed, 3 Jan 2018 16:35:02 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Andi Kleen <andi@...stfloor.org>
Cc:     tglx@...uxtronix.de, torvalds@...ux-foundation.org,
        gregkh@...ux-foundation.org, dwmw@...zon.co.uk,
        tim.c.chen@...ux.intel.com, linux-kernel@...r.kernel.org,
        dave.hansen@...el.com, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 10/11] retpoline/taint: Taint kernel for missing retpoline
 in compiler

On 01/03/2018 04:29 PM, Thomas Gleixner wrote:
> On Wed, 3 Jan 2018, Andi Kleen wrote:
>>  	unwind_init();
>> +
>> +#ifndef RETPOLINE
>> +	add_taint(TAINT_NO_RETPOLINE, LOCKDEP_STILL_OK);
>> +	pr_warn("No support for retpoline in kernel compiler\n");
>> +	pr_warn("Kernel may be vulnerable to data leaks.\n");
> 
> That's blantantly wrong.
> 
> The kernel is not vulnerable to data leaks. The hardware is.

Well it's the kernel that is vulnerable.  The warning doesn't say what is
causing the vulnerability, unless it's the "kernel compiler."

> An that's what the CPU_BUG bit is for. If the mitigation is in place,
> activate the proper feature bit like we did with PTI

> So you say, that we finally need a perl interpreter in the kernel to do
> alternative patching?

Yes, Finally.

-- 
~Randy