linux-kernel - Re: [PATCH v5 3/7] scsi: libsas: make the event threshold configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Jan 2018 10:04:25 +0000
From:   John Garry <john.garry@...wei.com>
To:     Hannes Reinecke <hare@...e.de>, Jason Yan <yanaijie@...wei.com>,
        <martin.petersen@...cle.com>, <jejb@...ux.vnet.ibm.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <zhaohongjiang@...wei.com>, <hare@...e.com>,
        <dan.j.williams@...el.com>, <jthumshirn@...e.de>,
        <Raj.Dinesh@...rosemi.com>, <hch@....de>,
        <huangdaode@...ilicon.com>, <chenxiang66@...ilicon.com>,
        <xiyou.wangcong@...il.com>, Ewan Milne <emilne@...hat.com>,
        Tomas Henzl <thenzl@...hat.com>
Subject: Re: [PATCH v5 3/7] scsi: libsas: make the event threshold
 configurable

On 15/12/2017 12:19, Hannes Reinecke wrote:
> On 12/08/2017 10:42 AM, Jason Yan wrote:
>> Add a sysfs attr that LLDD can configure it for every host. We made
>> a example in hisi_sas. Other LLDDs using libsas can implement it if
>> they want.
>>
>> Suggested-by: Hannes Reinecke <hare@...e.com>
>> Signed-off-by: Jason Yan <yanaijie@...wei.com>
>> CC: John Garry <john.garry@...wei.com>
>> CC: Johannes Thumshirn <jthumshirn@...e.de>
>> CC: Ewan Milne <emilne@...hat.com>
>> CC: Christoph Hellwig <hch@....de>
>> CC: Tomas Henzl <thenzl@...hat.com>
>> CC: Dan Williams <dan.j.williams@...el.com>
>> ---
>>  drivers/scsi/hisi_sas/hisi_sas_main.c |  6 ++++++
>>  drivers/scsi/libsas/sas_init.c        | 31 +++++++++++++++++++++++++++++++
>>  include/scsi/libsas.h                 |  1 +
>>  3 files changed, 38 insertions(+)
>>
> Ah, here is it now.
> So ignore that part of my previous comment.
>

Hi Hannes,

Thanks for checking this.

Can you please re-review "[PATCH v5 2/7] scsi: libsas: shut down the PHY 
if events reached the threshold" to see if you are happy with it? We 
have no tag currently.

Very much appreciated,
John

> Reviewed-by: Hannes Reinecke <hare@...e.com>
>
> Cheers,
>
> Hannes
>