linux-kernel - Re: [RESEND PATCH v2 14/15] ASoC: qcom: apq8096: Add db820c machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180104120244.GE10774@sirena.org.uk>
Date:   Thu, 4 Jan 2018 12:02:44 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     srinivas.kandagatla@...aro.org, Andy Gross <andy.gross@...aro.org>,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Patrick Lai <plai@...eaurora.org>,
        Banajit Goswami <bgoswami@...eaurora.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [RESEND PATCH v2 14/15] ASoC: qcom: apq8096: Add db820c machine
 driver

On Wed, Jan 03, 2018 at 09:20:45AM -0800, Stephen Boyd wrote:
> On 12/14/2017 09:34 AM, srinivas.kandagatla@...aro.org wrote:

> > uThis patch adds support to DB820c machine driver.

> > +	ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(32));

> Why do we need to do this? Can you add some sort of comment in the code
> about why?

And why are we applying DMA restrictions in a machine driver?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)