linux-kernel - Re: [PATCH v4 5/7] clk: Introduce davinci clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0165dc8-c23c-c939-d1b7-f10be3b10553@ti.com>
Date:   Thu, 4 Jan 2018 18:13:29 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     David Lechner <david@...hnology.com>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     Kevin Hilman <khilman@...nel.org>, Adam Ford <aford173@...il.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 5/7] clk: Introduce davinci clocks

Hi David,

On Monday 01 January 2018 05:09 AM, David Lechner wrote:
> +	/* TODO: old davinci clocks for da850 set MDCTL_FORCE bit for sata and
> +	 * dsp here. Is this really needed?
> +	 */

The commit that introduced this flag suggests so.

commit aad70de20fc69970a3080e7e8f02b54a4a3fe3e6
Author:     Sekhar Nori <nsekhar@...com>
AuthorDate: Wed Jul 6 06:01:22 2011 +0000
Commit:     Sekhar Nori <nsekhar@...com>
CommitDate: Fri Jul 8 11:10:09 2011 +0530

    davinci: enable forced transitions on PSC

    Some DaVinci modules like the SATA on DA850
    need forced module state transitions.

    Define a "force" flag which can be passed to
    the PSC config function to enable it to make
    forced transitions.

    Forced transitions shouldn't normally be attempted,
    unless the TRM explicitly specifies its usage.

    ChangeLog:
    v2:
    Modified to take care of the fact that
    davinci_psc_config() now takes the flags
    directly.

    Signed-off-by: Sekhar Nori <nsekhar@...com>

I can check without that flag again, but I do recall it being needed.

Thanks,
Sekhar