linux-kernel - Re: [PATCH] staging: android: check the return value of register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180104145522.ru7twjwzmzzrqatd@mwanda>
Date:   Thu, 4 Jan 2018 17:55:22 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Xiongwei Song <sxwjean@...il.com>
Cc:     gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
        maco@...roid.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: check the return value of
 register_shrinker

On Thu, Jan 04, 2018 at 08:08:53AM +0800, Xiongwei Song wrote:
> register_shrinker call is made in ashmem_init, it may return error code,
> so we need to check it.
> 
> Signed-off-by: Xiongwei Song <sxwjean@...il.com>
> ---
>  drivers/staging/android/ashmem.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 4e8947923904..0b23c3e25cd4 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -854,12 +854,18 @@ static int __init ashmem_init(void)
>  		goto out_free2;
>  	}
>  
> -	register_shrinker(&ashmem_shrinker);
> +	ret = register_shrinker(&ashmem_shrinker);
> +	if (unlikely(ret)) {

Don't add the unlikely() here.  It hurts readability and this is not a
fast path.  I know the other callers all have it...  :/

regards,
dan carpenter