linux-kernel - Re: [PATCH] vfb: fix video mode and line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 04 Jan 2018 16:05:15 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     "Pieter \"PoroCYon\" Sluys" <pcy@...ional.shitposting.agency>
Cc:     linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] vfb: fix video mode and line_length being set when
 loaded

On Wednesday, December 20, 2017 02:53:00 PM Pieter PoroCYon Sluys wrote:
> Geert Uytterhoeven:
> > Please add your "Signed-off-by", cfr.
> > Documentation/process/submitting-patches.rst.
> 
> Sorry I knew I would've messed up *something*.
> 
> > You can drop the tests for 2 and 4, as these are no longer used by the driver.
> 
> Done that.
> 
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Signed-off-by: Pieter "PoroCYon" Sluys <pcy@...ional.shitposting.agency>

I've queued your patch for 4.16 kernel (after fixing few minor
issues [*]), thanks!

[*] next time please remember to:

* always include full patch description in the later patch revisions

* put things that don't belong to patch description after "---" so
  they will not be included in the final commit

* in the later patch revisions include ChangeLog after "---" and also
  put patch version in the patch summary line / mail subject
  (i.e. "[PATCH v2] ...")

* add tags (i.e. "Reviewed-by: ...") from patch reviewers / testers
  into the patch description

* check your patch with scripts/checkpatch.pl tool and fix reported
  issues, i.e.:

ERROR: switch and case should be at the same indent
#69: FILE: drivers/video/fbdev/vfb.c:242:
+       switch (info->var.bits_per_pixel) {
+               case 1:
[...]
+               case 8:
[...]
+               case 16:
+               case 24:
+               case 32:

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics