linux-kernel - Re: [PATCH][V2] wcn36xx: fix incorrect assignment to msg_body.min_ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Jan 2018 09:40:39 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Eugene Krasnikov <k.eugene.e@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>, wcn36xx@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] wcn36xx: fix incorrect assignment to
 msg_body.min_ch_time

On Fri 29 Dec 01:07 PST 2017, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> The second assignment to msg_body.min_ch_time is incorrect, it
> should actually be to msg_body.max_ch_time.
> 
> Thanks to Bjorn Andersson for identifying the correct way to fix
> this as my original fix was incorrect.
> 
> Detected by CoverityScan, CID#1463042 ("Unused Value")
> 
> Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks Colin,

Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  drivers/net/wireless/ath/wcn36xx/smd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 2914618a0335..2a4871ca9c72 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -626,7 +626,7 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif,
>  
>  	msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE;
>  	msg_body.min_ch_time = 30;
> -	msg_body.min_ch_time = 100;
> +	msg_body.max_ch_time = 100;
>  	msg_body.scan_hidden = 1;
>  	memcpy(msg_body.mac, vif->addr, ETH_ALEN);
>  	msg_body.p2p_search = vif->p2p;
> -- 
> 2.14.1
>