linux-kernel - Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180104194405.GD27975@Asurada-Nvidia>
Date:   Thu, 4 Jan 2018 11:44:06 -0800
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:     timur@...i.org, broonie@...nel.org, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, alsa-devel@...a-project.org,
        lgirdwood@...il.com, fabio.estevam@....com, caleb@...me.org,
        arnaud.mouiche@...oxia.com, lukma@...x.de, kernel@...gutronix.de
Subject: Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of
 trigger()

On Mon, Jan 01, 2018 at 10:59:30PM +0100, Maciej S. Szmigiero wrote:

> > +static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx)

> > +		srcr = vals[tx].srcr;
> > +		stcr = vals[tx].stcr;
> > +		sier = vals[tx].sier;
> 
> Implicit assumption here that RX == 0, TX == 1, as in the 03 patch.

Could replace it with "bool dir" as well. Thanks for the review.