linux-kernel - Re: [RFC PATCH 1/4] asm-generic/barrier: add generic nospec helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180105091529.b7jip2q4a44esmh4@salmiak>
Date:   Fri, 5 Jan 2018 09:15:29 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Dan Williams <dan.j.williams@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch@...r.kernel.org, Will Deacon <will.deacon@....com>
Subject: Re: [RFC PATCH 1/4] asm-generic/barrier: add generic nospec helpers

On Thu, Jan 04, 2018 at 08:21:56PM -0800, Dan Williams wrote:
> On Thu, Jan 4, 2018 at 4:00 AM, Mark Rutland <mark.rutland@....com> wrote:
> > On Wed, Jan 03, 2018 at 10:38:24PM +0000, Mark Rutland wrote:
> >> +#define nospec_array_load(arr, idx, sz)                                      \
> >> +({                                                                   \
> >> +     typeof(*(arr)) *__arr = arr;                                    \
> >> +     typeof(idx) __idx = idx;                                        \
> >> +     typeof(sz) __sz = __sz;                                         \
> >
> > Whoops. The second __sz should be sz here.
> 
> Those should all have parenthesis on the args too, right?

Probably, yes.

I've added those to the version in my core/nospec branch.

Thanks,
Mark.