linux-kernel - Re: [rdma for-next] bnxt_re: report RoCE device support at info level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANjDDBho+uSNdzB3xg0v81fnEF-dbtMikWmftRRC9XyoUdjipw@mail.gmail.com>
Date:   Fri, 5 Jan 2018 15:22:02 +0530
From:   Devesh Sharma <devesh.sharma@...adcom.com>
To:     Jonathan Toppins <jtoppins@...hat.com>
Cc:     linux-rdma <linux-rdma@...r.kernel.org>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [rdma for-next] bnxt_re: report RoCE device support at info level

Acked-By: Devesh Sharma <devesh.sharma@...adcom.com>

On Fri, Jan 5, 2018 at 2:34 AM, Jonathan Toppins <jtoppins@...hat.com> wrote:
> Reporting that a device doesn't support RoCE seems like a valuable piece
> of information to have when trying to determine why a driver is not binding
> to a device. Better to report this at info log level instead of requiring
> a user to enable all debug messages in the driver.
>
> Signed-off-by: Jonathan Toppins <jtoppins@...hat.com>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index aafc19aa5de1..bf268bf1f496 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -417,7 +417,7 @@ static struct bnxt_en_dev *bnxt_re_dev_probe(struct net_device *netdev)
>                 return ERR_PTR(-EINVAL);
>
>         if (!(en_dev->flags & BNXT_EN_FLAG_ROCE_CAP)) {
> -               dev_dbg(&pdev->dev,
> +               dev_info(&pdev->dev,
>                         "%s: probe error: RoCE is not supported on this device",
>                         ROCE_DRV_MODULE_NAME);
>                 return ERR_PTR(-ENODEV);
> --
> 2.13.6
>