linux-kernel - Re: [RFC PATCH] asm/generic: introduce if_nospec and nospec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CACVxJT9cH3fbhjbWEfdpAuDfWtzv3cgVrxFU=o6JZ2fUML0wsw@mail.gmail.com>
Date:   Fri, 5 Jan 2018 12:33:45 +0200
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     viro@...iv.linux.org.uk
Cc:     linux-kernel@...r.kernel.org, dave.hansen@...el.com,
        dan.j.williams@...el.com, ebiederm@...ssion.com,
        gnomes@...rguk.ukuu.org.uk, jikos@...nel.org,
        torvalds@...ux-foundation.org
Subject: Re: [RFC PATCH] asm/generic: introduce if_nospec and nospec_barrier

Al Viro wrote:
> > > No, the concern is that an fd value >= fdt->max_fds may cause the cpu
> > > to read arbitrary memory addresses relative to files->fdt and
> > > userspace can observe that it got loaded.
> >
> > Yes.  And all that might reveal is the value of files->fdt.  Who cares?
>
> Sorry, s/files->fdt/files->fdt->fd/.  Still the same question - what information
> would that extract and how would attacker use that?

Al, paper exploit requires second data dependent load but they only do it
for easy demonstration.

    struct file *file = (fd < fdt->max_fds) ? fdt->fd[fd] : NULL;
    if (file && (file->f_mode & mask))
        ...

Speculative "struct file *" can be anything.
If ->f_mode access happens cacheline will be primed.
If pointer is userspace address nothing will happen because of SMAP.

Now you know that some data past fdtable looks like canonical kernel
address.