linux-kernel - Re: [PATCH v10 12/15] platform/x86: dell-smbios: Add filtering support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180105111313.23c6vjs2x3fhtvi4@pali>
Date:   Fri, 5 Jan 2018 12:13:13 +0100
From:   Pali Rohár <pali.rohar@...il.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     dvhart@...radead.org, Andy Shevchenko <andy.shevchenko@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>, quasisec@...gle.com,
        rjw@...ysocki.net, mjg59@...gle.com, hch@....de,
        Greg KH <greg@...ah.com>, Alan Cox <gnomes@...rguk.ukuu.org.uk>
Subject: Re: [PATCH v10 12/15] platform/x86: dell-smbios: Add filtering
 support

I know that this patch is already applied and merged, but I spotted this
problem:

On Thursday 19 October 2017 12:50:15 Mario Limonciello wrote:
> +/* calls that are explicitly blacklisted */
> +static struct smbios_call call_blacklist[] = {
> +	{0x0000, 01, 07}, /* manufacturing use */
> +	{0x0000, 06, 05}, /* manufacturing use */
> +	{0x0000, 11, 03}, /* write once */
> +	{0x0000, 11, 07}, /* write once */

Numbers prefixed by zero means that they are in octal notation, right?
This can lead to misunderstanding, confusion or problems in future...

Can we have all numbers either in hexadecimal or decimal notation?

> +	{0x0000, 11, 11}, /* write once */
> +	{0x0000, 19, -1}, /* diagnostics */
> +	/* handled by kernel: dell-laptop */
> +	{0x0000, CLASS_INFO, SELECT_RFKILL},
> +	{0x0000, CLASS_KBD_BACKLIGHT, SELECT_KBD_BACKLIGHT},
> +};

-- 
Pali Rohár
pali.rohar@...il.com