linux-kernel - Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b08c2c97-1245-4ec5-a3ae-738b0755832e@linaro.org>
Date:   Fri, 5 Jan 2018 11:40:57 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Vincent Legoll <vincent.legoll@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Byungchul Park <byungchul.park@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all



On 09/12/17 16:27, Vincent Legoll wrote:
> No need to get into the submenu to disable all related
> config entries.
> 
> This makes it easier to disable all RUNTIME_TESTS config options
> without entering the submenu. It will also enable one to see that
> en/dis-abled state from the outside menu.
> 
> This is only intended to change menuconfig UI, not change
> the config dependencies.

Wouldn't you need a "default y" applied to the menuconfig to achieve this?

With this patch applied defconfigs that enable LKDTM by default will no 
longer do so (default_defconfig from arch/s390 is an example although 
there are others).


Daniel.


> 
> Signed-off-by: Vincent Legoll <vincent.legoll@...il.com>
> ---
>   lib/Kconfig.debug | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 947d3e2ed5c2..9436714254b7 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1660,7 +1660,10 @@ config DMA_API_DEBUG
>   
>   	  If unsure, say N.
>   
> -menu "Runtime Testing"
> +menuconfig RUNTIME_TESTING_MENU
> +	bool "Runtime Testing"
> +
> +if RUNTIME_TESTING_MENU
>   
>   config LKDTM
>   	tristate "Linux Kernel Dump Test Tool Module"
> @@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL
>   
>   	  If unsure, say N.
>   
> -endmenu # runtime tests
> +endif # RUNTIME_TESTING_MENU
>   
>   config MEMTEST
>   	bool "Memtest"
>