linux-kernel - Re: [PATCH v2] tick/broadcast: Remove redundant code in tick_check_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f4c1f74f-439e-4931-b003-f135e3b0d5ea@default>
Date:   Thu, 4 Jan 2018 17:28:07 -0800 (PST)
From:   Zhenzhong Duan <zhenzhong.duan@...cle.com>
To:     <tglx@...utronix.de>, <mingo@...nel.org>, <fweisbec@...il.com>
Cc:     <srinivas.eeda@...cle.com>, <joe.jin@...cle.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] tick/broadcast: Remove redundant code in
 tick_check_new_device()

Hi Maintainers,

Any comment for this v2?

Thanks
zduan
----- zhenzhong.duan@...cle.com wrote:

> There is no way a timer used as broadcast clockevent device is also
> used as
> percpu tick clockevent device currently.
> 
> -v2: remove meaningless description suggested by tglx
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...cle.com>
> ---
>  kernel/time/tick-common.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
> index 49edc1c..9bcc866 100644
> --- a/kernel/time/tick-common.c
> +++ b/kernel/time/tick-common.c
> @@ -320,13 +320,8 @@ void tick_check_new_device(struct
> clock_event_device *newdev)
>  
>  	/*
>  	 * Replace the eventually existing device by the new
> -	 * device. If the current device is the broadcast device, do
> -	 * not give it back to the clockevents layer !
> +	 * device.
>  	 */
> -	if (tick_is_broadcast_device(curdev)) {
> -		clockevents_shutdown(curdev);
> -		curdev = NULL;
> -	}
>  	clockevents_exchange_device(curdev, newdev);
>  	tick_setup_device(td, newdev, cpu, cpumask_of(cpu));
>  	if (newdev->features & CLOCK_EVT_FEAT_ONESHOT)
> -- 
> 1.7.3