linux-kernel - Re: [PATCH] x86/pti: Rename BUG_CPU_INSECURE to BUG_CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Jan 2018 15:24:51 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Tom Lendacky <thomas.lendacky@....com>
cc:     "Woodhouse, David" <dwmw@...zon.co.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tim.c.chen@...ux.intel.com" <tim.c.chen@...ux.intel.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "riel@...hat.com" <riel@...hat.com>,
        "keescook@...gle.com" <keescook@...gle.com>,
        "gnomes@...rguk.ukuu.org.uk" <gnomes@...rguk.ukuu.org.uk>,
        "pjt@...gle.com" <pjt@...gle.com>,
        "dave.hansen@...el.com" <dave.hansen@...el.com>,
        "luto@...capital.net" <luto@...capital.net>,
        "jikos@...nel.org" <jikos@...nel.org>,
        "gregkh@...ux-foundation.org" <gregkh@...ux-foundation.org>
Subject: Re: [PATCH] x86/pti: Rename BUG_CPU_INSECURE to BUG_CPU_MELTDOWN

On Fri, 5 Jan 2018, Tom Lendacky wrote:

> On 1/5/2018 8:10 AM, Thomas Gleixner wrote:
> > Use the name associated with the attack which needs page table isolation
> > for mitigation.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> > ---
> >  arch/x86/include/asm/cpufeatures.h |    2 +-
> >  arch/x86/mm/pti.c                  |    6 +++---
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> Don't you need to update the value in arch/x86/kernel/cpu/common.c, also?

Indeed. I'm sure I wanted to :)

> Thanks,
> Tom
> 
> > 
> > --- a/arch/x86/include/asm/cpufeatures.h
> > +++ b/arch/x86/include/asm/cpufeatures.h
> > @@ -341,6 +341,6 @@
> >  #define X86_BUG_SWAPGS_FENCE		X86_BUG(11) /* SWAPGS without input dep on GS */
> >  #define X86_BUG_MONITOR			X86_BUG(12) /* IPI required to wake up remote CPU */
> >  #define X86_BUG_AMD_E400		X86_BUG(13) /* CPU is among the affected by Erratum 400 */
> > -#define X86_BUG_CPU_INSECURE		X86_BUG(14) /* CPU is insecure and needs kernel page table isolation */
> > +#define X86_BUG_CPU_MELTDOWN		X86_BUG(14) /* CPU is affected by meltdown attack and needs kernel page table isolation */
> >  
> >  #endif /* _ASM_X86_CPUFEATURES_H */
> > --- a/arch/x86/mm/pti.c
> > +++ b/arch/x86/mm/pti.c
> > @@ -56,13 +56,13 @@
> >  
> >  static void __init pti_print_if_insecure(const char *reason)
> >  {
> > -	if (boot_cpu_has_bug(X86_BUG_CPU_INSECURE))
> > +	if (boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN))
> >  		pr_info("%s\n", reason);
> >  }
> >  
> >  static void __init pti_print_if_secure(const char *reason)
> >  {
> > -	if (!boot_cpu_has_bug(X86_BUG_CPU_INSECURE))
> > +	if (!boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN))
> >  		pr_info("%s\n", reason);
> >  }
> >  
> > @@ -96,7 +96,7 @@ void __init pti_check_boottime_disable(v
> >  	}
> >  
> >  autosel:
> > -	if (!boot_cpu_has_bug(X86_BUG_CPU_INSECURE))
> > +	if (!boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN))
> >  		return;
> >  enable:
> >  	setup_force_cpu_cap(X86_FEATURE_PTI);
> > 
>