linux-kernel - Re: [PATCH] DAC960: split up ioctl function to reduce stack size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4deb8455-a133-5fa5-0219-74323c1fdc28@kernel.dk>
Date:   Fri, 5 Jan 2018 09:41:02 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] DAC960: split up ioctl function to reduce stack size

On 12/11/17 5:11 AM, Arnd Bergmann wrote:
> When CONFIG_KASAN is set, all the local variables in this function are
> allocated on the stack together, leading to a warning about possible
> kernel stack overflow:
> 
> drivers/block/DAC960.c: In function 'DAC960_gam_ioctl':
> drivers/block/DAC960.c:7061:1: error: the frame size of 2240 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
> 
> By splitting up the function into smaller chunks, we can avoid that and
> make the code slightly more readable at the same time. The coding style
> in this file is completely nonstandard, and I chose to not touch that
> at all, leaving the unconventional intendation unchanged to make it
> easier to review the diff.

Applied, thanks Arnd.

-- 
Jens Axboe