linux-kernel - RE: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of variable c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <461db48ecc3c479c9789340bf3608e8b@microsemi.com>
Date:   Fri, 5 Jan 2018 16:42:25 +0000
From:   Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>
To:     Colin King <colin.king@...onical.com>,
        dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of
 variable c


> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: Friday, January 5, 2018 7:31 AM
> To: dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>; James E . J .
> Bottomley <jejb@...ux.vnet.ibm.com>; Martin K . Petersen
> <martin.petersen@...cle.com>; linux-scsi@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of
> variable c
> 
> EXTERNAL EMAIL
> 
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> A previous commit no longer stores the contents of c, so we now have
> a situation where c is being updated but the value is never read. Clean
> up the code by removing the now redundant setting of variable c.
> 
> Cleans up clang warning:
> drivers/scsi/aacraid/aachba.c:943:3: warning: Value stored to 'c' is
> never read
> 
> Fixes: f4e8708d3104 ("scsi: aacraid: Fix udev inquiry race condition")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
Reviewed-by :Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>