linux-kernel - Re: [alsa-devel] [PATCH v6 07/14] regmap: Add SoundWire bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98480de5-cd6b-845f-df1d-c9593596055f@linux.intel.com>
Date:   Fri, 5 Jan 2018 11:22:15 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>, Vinod Koul <vinod.koul@...el.com>
Cc:     ALSA <alsa-devel@...a-project.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sudheer Papothi <spapothi@...eaurora.org>,
        Takashi <tiwai@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        plai@...eaurora.org, LKML <linux-kernel@...r.kernel.org>,
        patches.audio@...el.com, srinivas.kandagatla@...aro.org,
        Sagar Dharia <sdharia@...eaurora.org>, alan@...ux.intel.com
Subject: Re: [alsa-devel] [PATCH v6 07/14] regmap: Add SoundWire bus support

On 1/5/18 11:04 AM, Mark Brown wrote:
> On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote:
> 
>> +	/* SoundWire register address are contiguous */
>> +	if (config->reg_stride != 0)
>> +		return -ENOTSUPP;
> 
> That doesn't mean the chip hasn't decided not to use half the addresses
> for some reason - this isn't something the bus should be enforcing.

Good point. The contiguous requirement is valid only for normative 
registers, where the device has no choice but to follow the standard. 
For the imp-def part where regmap would typically be used, then indeed 
there is no restriction, chip implementers can do whatever they want.
I have a vague memory that regmap was only intended to be used for this 
latter case, but Vinod and team should clarify this.