linux-kernel - Re: [V4, 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180105185544.GD17719@n2100.armlinux.org.uk>
Date:   Fri, 5 Jan 2018 18:55:44 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        Andrew Morton <akpm@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Christoph Hellwig <hch@....de>,
        Rob Herring <rob.herring@...aro.org>,
        Jonas Oberg <jonas@...e.org>, Joe Perches <joe@...ches.com>,
        linux-xfs@...r.kernel.org,
        Charlemagne Lasse <charlemagnelasse@...il.com>,
        Carmen Bianca Bakker <carmenbianca@...e.org>
Subject: Re: [V4, 01/11] Documentation: Add license-rules.rst to describe how
 to properly identify file licenses

On Fri, Jan 05, 2018 at 02:05:26PM +0100, Alexandre Belloni wrote:
> Hi,
> 
> I'm definitively late to the party but...
> 
> On 17/11/2017 at 11:00:33 +0100, Thomas Gleixner wrote:
> > +2. Style:
> > +
> > +   The SPDX license identifier is added in form of a comment.  The comment
> > +   style depends on the file type::
> > +
> > +      C source:   // SPDX-License-Identifier: <SPDX License Expression>
> > +      C header:   /* SPDX-License-Identifier: <SPDX License Expression> */
> > +      ASM:        /* SPDX-License-Identifier: <SPDX License Expression> */
> > +      scripts:    # SPDX-License-Identifier: <SPDX License Expression>
> > +      .rst:	  .. SPDX-License-Identifier: <SPDX License Expression>
> > +      .dts{i}:	  // SPDX-License-Identifier: <SPDX License Expression>
> 
> dtc doesn't handle // comments. This works in the kernel tree because
> dts files are preprocessed by CPP. But this doesn't work when using dtc
> directly (most likely when compiling DT overlays). So, the choice is
> between making dtc handle // comments or changing the documentation.

Does all the CPP macros that we use for things like GPIOs work when you
avoid CPP?

What I'm saying is that preprocessing the DTS in the kernel tree with
CPP appears to be a necessity, and doing so will deal with the C++
comments.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up