linux-kernel - [PATCH] console/dummy: leave .con_font

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YSQ.7.76.1801051636340.1528@knanqh.ubzr>
Date:   Fri, 5 Jan 2018 16:42:58 -0500 (EST)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] console/dummy: leave .con_font_get set to NULL


When this method is set, the caller expects struct console_font fields
to be properly initialized when it returns. Leave it unset otherwise
nonsensical (leaked kernel stack) values are returned to user space.

Signed-off-by: Nicolas Pitre <nico@...aro.org>
Cc: stable@...nel.org

diff --git a/drivers/video/console/dummycon.c b/drivers/video/console/dummycon.c
index 9269d56852..b90ef96e43 100644
--- a/drivers/video/console/dummycon.c
+++ b/drivers/video/console/dummycon.c
@@ -67,7 +67,6 @@ const struct consw dummy_con = {
     .con_switch =	DUMMY,
     .con_blank =	DUMMY,
     .con_font_set =	DUMMY,
-    .con_font_get =	DUMMY,
     .con_font_default =	DUMMY,
     .con_font_copy =	DUMMY,
 };