linux-kernel - Re: [RFC PATCH 1/4] asm-generic/barrier: add generic nospec helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA9_cmcWHc_068kHEDQ2DNcTZNFBAypmkhznnVODKccnuLFFOg@mail.gmail.com>
Date:   Thu, 4 Jan 2018 20:21:56 -0800
From:   Dan Williams <dan.j.williams@...il.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch@...r.kernel.org, Will Deacon <will.deacon@....com>
Subject: Re: [RFC PATCH 1/4] asm-generic/barrier: add generic nospec helpers

On Thu, Jan 4, 2018 at 4:00 AM, Mark Rutland <mark.rutland@....com> wrote:
> On Wed, Jan 03, 2018 at 10:38:24PM +0000, Mark Rutland wrote:
>> +#define nospec_array_load(arr, idx, sz)                                      \
>> +({                                                                   \
>> +     typeof(*(arr)) *__arr = arr;                                    \
>> +     typeof(idx) __idx = idx;                                        \
>> +     typeof(sz) __sz = __sz;                                         \
>
> Whoops. The second __sz should be sz here.

Those should all have parenthesis on the args too, right?