linux-kernel - Re: [PATCH] arch/x86/boot: sizeof macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180106115020.abragiirty5edis5@gmail.com>
Date:   Sat, 6 Jan 2018 12:50:20 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Saidgani Musaev <cpu808694@...il.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/x86/boot: sizeof macro


* Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Fri, Dec 29, 2017 at 9:46 PM, Ingo Molnar <mingo@...nel.org> wrote:
> > * Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> 
> >> > -       ireg.cx  = sizeof buf;
> >> > +       ireg.cx  = sizeof(buf);
> >>
> >> sizeof is operator, not a function.
> >> So, what are you trying to achieve?
> >
> > That's true, but in the kernel coding style we use it as a function:
> 
> Yeah, the question is do we need to change all those 177 occurrences at all?
> Or perhaps it might be an opportunity during some other changes to
> certain users...

We probably don't want to change then, and my point was that 99.8% of the current 
usage is as a 'function':

  triton:~/tip> git grep 'sizeof(' | wc -l
  116570

  triton:~/tip> git grep 'sizeof [:alnum:]' | wc -l
  177

i.e. your patch moves it in the exact wrong direction.

Thanks,

	Ingo