linux-kernel - Re: [PATCH v2 0/8] IBRS patch series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515240003.29312.241.camel@amazon.co.uk>
Date:   Sat, 6 Jan 2018 12:00:03 +0000
From:   "Woodhouse, David" <dwmw@...zon.co.uk>
To:     Tim Chen <tim.c.chen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg KH <gregkh@...uxfoundation.org>
CC:     Dave Hansen <dave.hansen@...el.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@...el.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/8] IBRS patch series

On Fri, 2018-01-05 at 22:43 -0800, Tim Chen wrote:
> 
> On 01/05/2018 06:12 PM, Tim Chen wrote:
> > 
> > Thanks to everyone for the feedback on the initial posting.
> > This is an updated patchset and I hope I've captured all
> > the review comments.  I've done a lot of code clean up
> > per everyone's comments. Please let me know if I've missed
> > something.
> > 
> Should also have mentioned that the patch series applies on
> top of 4.15-rc6.

If you're going to set/clear the X86_FEATURE_RETPOLINE and
X86_FEATURE_RETPOLINE_AMD features (sorry, there are two of them now.
Blame Linus), you probably want to base on the retpoline branch
instead? It was Arjan's choice to put retpoline first, wasn't it?

In the last few days we've gone from a coherent patch series which was
far from perfect but which was at least basically complete and
functional, to disparate patch series all of which conflict. And some
of which haven't even been posted publicly yet at all (IBPB, and I
still haven't actually seen the variant 1 patches in public).

It would be really good to pull everything together, even if it's going
to receive significant bikeshedding.
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5210 bytes)