linux-kernel - Re: [PATCH 11/12] iio: common: ssp_sensors: account for const type of of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 Jan 2018 12:23:06 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     kernel-janitors@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/12] iio: common: ssp_sensors: account for const type
 of of_device_id.data

On Tue,  2 Jan 2018 14:28:07 +0100
Julia Lawall <Julia.Lawall@...6.fr> wrote:

> This driver creates a number of const structures that it stores in the
> data field of an of_device_id array.
> 
> Add const to the declaration of the location that receives a value
> from the data field to ensure that the compiler will continue to check
> that the value is not modified and remove the const-dropping cast on
> the access to the data field.
> 
> Done using Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Thanks. Applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to play with it.

Jonathan

> 
> ---
>  drivers/iio/common/ssp_sensors/ssp.h     |    2 +-
>  drivers/iio/common/ssp_sensors/ssp_dev.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff -u -p a/drivers/iio/common/ssp_sensors/ssp.h b/drivers/iio/common/ssp_sensors/ssp.h
> --- a/drivers/iio/common/ssp_sensors/ssp.h
> +++ b/drivers/iio/common/ssp_sensors/ssp.h
> @@ -188,7 +188,7 @@ struct ssp_sensorhub_info {
>   */
>  struct ssp_data {
>  	struct spi_device *spi;
> -	struct ssp_sensorhub_info *sensorhub_info;
> +	const struct ssp_sensorhub_info *sensorhub_info;
>  	struct timer_list wdt_timer;
>  	struct work_struct work_wdt;
>  	struct delayed_work work_refresh;
> diff -u -p a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -486,7 +486,7 @@ static struct ssp_data *ssp_parse_dt(str
>  	if (!match)
>  		goto err_mcu_reset_gpio;
>  
> -	data->sensorhub_info = (struct ssp_sensorhub_info *)match->data;
> +	data->sensorhub_info = match->data;
>  
>  	dev_set_drvdata(dev, data);
>  
>