lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 6 Jan 2018 13:46:39 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-mtd@...ts.infradead.org,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Brian Norris <computersforpeace@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        David Woodhouse <dwmw2@...radead.org>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH 2/3] mtd/nftlmount: Delete eight unwanted spaces behind
 function names

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 6 Jan 2018 12:55:23 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: space prohibited between function name and open parenthesis '('

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/mtd/nftlmount.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
index 6b9634a70229..d1eaa87c88ba 100644
--- a/drivers/mtd/nftlmount.c
+++ b/drivers/mtd/nftlmount.c
@@ -314,7 +314,7 @@ int NFTL_formatblock(struct NFTLrecord *nftl, int block)
 			  8, &retlen, (char *)&uci) < 0)
 		goto default_uci1;
 
-	erase_mark = le16_to_cpu ((uci.EraseMark | uci.EraseMark1));
+	erase_mark = le16_to_cpu(uci.EraseMark | uci.EraseMark1);
 	if (erase_mark != ERASE_MARK) {
 	default_uci1:
 		uci.EraseMark = cpu_to_le16(ERASE_MARK);
@@ -501,11 +501,12 @@ static int check_and_mark_free_block(struct NFTLrecord *nftl, int block)
 			  &retlen, (char *)&h1) < 0)
 		return -1;
 
-	erase_mark = le16_to_cpu ((h1.EraseMark | h1.EraseMark1));
+	erase_mark = le16_to_cpu(h1.EraseMark | h1.EraseMark1);
 	if (erase_mark != ERASE_MARK) {
 		/* if no erase mark, the block must be totally free. This is
 		   possible in two cases : empty filesystem or interrupted erase (very unlikely) */
-		if (check_free_sectors (nftl, block * nftl->EraseSize, nftl->EraseSize, 1) != 0)
+		if (check_free_sectors(nftl, block * nftl->EraseSize,
+				       nftl->EraseSize, 1) != 0)
 			return -1;
 
 		/* free block : write erase mark */
@@ -521,8 +522,9 @@ static int check_and_mark_free_block(struct NFTLrecord *nftl, int block)
 		/* if erase mark present, need to skip it when doing check */
 		for (i = 0; i < nftl->EraseSize; i += SECTORSIZE) {
 			/* check free sector */
-			if (check_free_sectors (nftl, block * nftl->EraseSize + i,
-						SECTORSIZE, 0) != 0)
+			if (check_free_sectors(nftl,
+					       block * nftl->EraseSize + i,
+					       SECTORSIZE, 0) != 0)
 				return -1;
 
 			if (nftl_read_oob(mtd, block * nftl->EraseSize + i,
@@ -608,10 +610,13 @@ int NFTL_mount(struct NFTLrecord *s)
 					break;
 				}
 
-				logical_block = le16_to_cpu ((h0.VirtUnitNum | h0.SpareVirtUnitNum));
-				rep_block = le16_to_cpu ((h0.ReplUnitNum | h0.SpareReplUnitNum));
-				nb_erases = le32_to_cpu (h1.WearInfo);
-				erase_mark = le16_to_cpu ((h1.EraseMark | h1.EraseMark1));
+				logical_block = le16_to_cpu(h0.VirtUnitNum |
+							    h0.SpareVirtUnitNum);
+				rep_block = le16_to_cpu(h0.ReplUnitNum |
+							h0.SpareReplUnitNum);
+				nb_erases = le32_to_cpu(h1.WearInfo);
+				erase_mark = le16_to_cpu(h1.EraseMark |
+							 h1.EraseMark1);
 
 				is_first_block = !(logical_block >> 15);
 				logical_block = logical_block & 0x7fff;
-- 
2.15.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ