linux-kernel - Re: PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180106132443.yzn2pkfruu7basl7@D-69-91-141-110.dhcp4.washington.edu>
Date:   Sat, 6 Jan 2018 08:24:43 -0500
From:   Alexandru Chirvasitu <achirvasub@...il.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>
Cc:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        intel-gfx@...ts.freedesktop.org,
        kernel list <linux-kernel@...r.kernel.org>
Subject: Re: PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

Thank you!

I'll apply that more elaborate patch you sent in the longer message to
my clone of the repo and see if it still freezes.

On Sat, Jan 06, 2018 at 10:43:20AM +0000, Chris Wilson wrote:
> Quoting Alexandru Chirvasitu (2018-01-05 22:05:18)
> > Here we go.
> > 
> > I have
> > 
> > CONFIG_PAGE_POISONING not set
> > CONFIG_SLUB_STATS=y
> > CONFIG_SLUB_DEBUG not set
> > CONFIG_KASAN=y
> > 
> > .config attached along as well for verification, in case I missed
> > anything.
> > 
> > Again crashed by an attempt to open a terminal window.
> 
> Gotcha,
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index b21322b50419..96cf46a10b4e 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -472,7 +472,7 @@ static void __fence_set_priority(struct dma_fence *fence, int prio)
>         struct drm_i915_gem_request *rq;
>         struct intel_engine_cs *engine;
>  
> -       if (!dma_fence_is_i915(fence))
> +       if (dma_fence_is_signaled(fence) || !dma_fence_is_i915(fence))
>                 return;
>  
>         rq = to_request(fence);