linux-kernel - Re: [PATCH] drm/nouveau/disp/gf119: add missing drive vfunc ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGu_F_QcvAu2WxC6soYGm16Oiw88UnjnSuzVx+cVU5hZDA@mail.gmail.com>
Date:   Sat, 6 Jan 2018 11:01:39 -0500
From:   Rob Clark <robdclark@...il.com>
To:     dri-devel <dri-devel@...ts.freedesktop.org>
Cc:     Rob Clark <robdclark@...il.com>, Ben Skeggs <bskeggs@...hat.com>,
        David Airlie <airlied@...ux.ie>, nouveau@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/nouveau/disp/gf119: add missing drive vfunc ptr

On Sat, Jan 6, 2018 at 10:59 AM, Rob Clark <robdclark@...il.com> wrote:
> Fixes broken dp on GF119:
>
>   Call Trace:
>    ? nvkm_dp_train_drive+0x183/0x2c0 [nouveau]
>    nvkm_dp_acquire+0x4f3/0xcd0 [nouveau]
>    nv50_disp_super_2_2+0x5d/0x470 [nouveau]
>    ? nvkm_devinit_pll_set+0xf/0x20 [nouveau]
>    gf119_disp_super+0x19c/0x2f0 [nouveau]
>    process_one_work+0x193/0x3c0
>    worker_thread+0x35/0x3b0
>    kthread+0x125/0x140
>    ? process_one_work+0x3c0/0x3c0
>    ? kthread_park+0x60/0x60
>    ret_from_fork+0x25/0x30
>   Code:  Bad RIP value.
>   RIP:           (null) RSP: ffffb1e243e4bc38
>   CR2: 0000000000000000
>
> Fixes: af85389c614a drm/nouveau/disp: shuffle functions around

This should probably also have:

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103421

> Signed-off-by: Rob Clark <robdclark@...il.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c
> index a2978a37b4f3..700fc754f28a 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/sorgf119.c
> @@ -174,6 +174,7 @@ gf119_sor = {
>                 .links = gf119_sor_dp_links,
>                 .power = g94_sor_dp_power,
>                 .pattern = gf119_sor_dp_pattern,
> +               .drive = gf119_sor_dp_drive,
>                 .vcpi = gf119_sor_dp_vcpi,
>                 .audio = gf119_sor_dp_audio,
>                 .audio_sym = gf119_sor_dp_audio_sym,
> --
> 2.14.3
>