linux-kernel - Re: [PATCH] Bluetooth: btintel: make array 'param' static, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1B85A899-6FB7-4BDB-B123-848C14BDFE54@holtmann.org>
Date:   Sat, 6 Jan 2018 17:43:52 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btintel: make array 'param' static, shrinks
 object size

Hi Colin,

> Don't populate the const read-only array 'param' on the stack but instead
> make it static. Makes the object code smaller by nearly 20 bytes:
> 
> Before:
>   text	   data	    bss	    dec	    hex	filename
>  11605	   2629	     64	  14298	   37da	linux/drivers/bluetooth/btintel.o
> 
> After:
>   text	   data	    bss	    dec	    hex	filename
>  11531	   2685	     64	  14280	   37c8	linux/drivers/bluetooth/btintel.o
> 
> (gcc version 7.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel