linux-kernel - Re: [PATCH v5 05/12] x86/retpoline/ftrace: Convert ftrace assembler indirect jumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzTj8NgE7LAXjpOoQj6RM9Zh7WNdweFUiuUmHTJ7Xmm+w@mail.gmail.com>
Date:   Sat, 6 Jan 2018 10:13:42 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     David Woodhouse <dwmw@...zon.co.uk>
Cc:     Andi Kleen <ak@...ux.intel.com>, Paul Turner <pjt@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...ux-foundation.org>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kees Cook <keescook@...gle.com>,
        Rik van Riel <riel@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...capital.net>,
        Jiri Kosina <jikos@...nel.org>,
        One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Subject: Re: [PATCH v5 05/12] x86/retpoline/ftrace: Convert ftrace assembler
 indirect jumps

On Sat, Jan 6, 2018 at 3:49 AM, David Woodhouse <dwmw@...zon.co.uk> wrote:
>
> -       call    *ftrace_trace_function
> +       movl    ftrace_trace_function, %ecx
> +       NOSPEC_CALL %ecx

Can't we just do

    NOSPEC_CALL ftrace_trace_function

now?

[ Goes off and looks ]

Oh. The AMD lfence version wants a register. Oh well.

             Linus