linux-kernel - Re: [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static

Open Source and information security mailing list archives

Message-ID: <20180106214413.7a8f9eea@bbrezillon>
Date:   Sat, 6 Jan 2018 21:44:13 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Andrea Adami <andrea.adami@...il.com>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org, Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Colin Ian King <colin.king@...onical.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH -next] mtd: sharpslpart: make local function
 sharpsl_nand_cleanup_ftl() static

On Fri, 22 Dec 2017 11:09:15 +0100
Andrea Adami <andrea.adami@...il.com> wrote:

> On Wed, Dec 20, 2017 at 6:45 AM, Wei Yongjun <weiyongjun1@...wei.com> wrote:
> > Fixes the following sparse warnings:
> >
> > drivers/mtd/parsers/sharpslpart.c:222:6: warning:
> >  symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> > ---
> >  drivers/mtd/parsers/sharpslpart.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> > index 0ddb79a..8893dc8 100644
> > --- a/drivers/mtd/parsers/sharpslpart.c
> > +++ b/drivers/mtd/parsers/sharpslpart.c
> > @@ -219,7 +219,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
> >         return ret;
> >  }
> >
> > -void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> > +static void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> >  {
> >         kfree(ftl->log2phy);
> >  }
> >  
> 
> Thanks, this should be indeed static like the other functions.
> 
> Acked-by: Andrea Adami <andrea.adami@...il.com>
> 

Applied.

Thanks,

Boris

> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives