linux-kernel - Re: [PATCH] staging: iio: light: Add breaks to lengthy lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 07 Jan 2018 08:42:27 -0800
From:   Joe Perches <joe@...ches.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        George Edward Bulmer <gebulmer@...glemail.com>
Cc:     gregkh@...uxfoundation.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, masneyb@...tation.org,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: light: Add breaks to lengthy lines

On Sun, 2018-01-07 at 16:28 +0000, Jonathan Cameron wrote:
> On Sun,  7 Jan 2018 15:08:01 +0000
> George Edward Bulmer <gebulmer@...glemail.com> wrote:
> 
> > This fixes three instances of checkpatch warning:
> > WARNING: line over 80 characters
> > 
> > Signed-off-by: George Edward Bulmer <gebulmer@...glemail.com>
> 
> Applied, thanks,

I believe these are examples of long line conversions
that should not be applied.

Most of the problem here is the very long identifier naming.
57 character identifiers are pretty unnecessary.

> Jonathan
> > ---
> >  drivers/staging/iio/light/tsl2x7x.c | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c
> > index 42ed9c015aaf..126e11530ce0 100644
> > --- a/drivers/staging/iio/light/tsl2x7x.c
> > +++ b/drivers/staging/iio/light/tsl2x7x.c
> > @@ -1441,7 +1441,8 @@ static irqreturn_t tsl2x7x_event_handler(int irq, void *private)
> >  
> >  static struct attribute *tsl2x7x_ALS_device_attrs[] = {
> >  	&dev_attr_in_illuminance0_calibscale_available.attr,
> > -	&iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > +	&iio_const_attr_in_illuminance0_integration_time_available
> > +		.dev_attr.attr,
> >  	&dev_attr_in_illuminance0_target_input.attr,
> >  	&dev_attr_in_illuminance0_calibrate.attr,
> >  	&dev_attr_in_illuminance0_lux_table.attr,
> > @@ -1455,7 +1456,8 @@ static struct attribute *tsl2x7x_PRX_device_attrs[] = {
> >  
> >  static struct attribute *tsl2x7x_ALSPRX_device_attrs[] = {
> >  	&dev_attr_in_illuminance0_calibscale_available.attr,
> > -	&iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > +	&iio_const_attr_in_illuminance0_integration_time_available
> > +		.dev_attr.attr,
> >  	&dev_attr_in_illuminance0_target_input.attr,
> >  	&dev_attr_in_illuminance0_calibrate.attr,
> >  	&dev_attr_in_illuminance0_lux_table.attr,
> > @@ -1471,7 +1473,8 @@ static struct attribute *tsl2x7x_PRX2_device_attrs[] = {
> >  
> >  static struct attribute *tsl2x7x_ALSPRX2_device_attrs[] = {
> >  	&dev_attr_in_illuminance0_calibscale_available.attr,
> > -	&iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> > +	&iio_const_attr_in_illuminance0_integration_time_available
> > +		.dev_attr.attr,
> >  	&dev_attr_in_illuminance0_target_input.attr,
> >  	&dev_attr_in_illuminance0_calibrate.attr,
> >  	&dev_attr_in_illuminance0_lux_table.attr,
> 
>