linux-kernel - Re: [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting ATMEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64398ab7-fbc6-0313-ccc6-51ff02d087e6@linaro.org>
Date:   Sun, 7 Jan 2018 19:07:13 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] clocksource/drivers: atmel-pit: allow unselecting
 ATMEL_PIT

On 05/01/2018 15:30, Alexandre Belloni wrote:
> With the new TCB clocksource driver, atmel platforms are now able to boot
> without the PIT driver. Allow unselecting it.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
>  drivers/clocksource/Kconfig | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 5609572e0236..55ccfa0ba63b 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -381,7 +381,14 @@ config ARMV7M_SYSTICK
>  
>  config ATMEL_PIT
>  	select TIMER_OF if OF
> -	def_bool SOC_AT91SAM9 || SOC_SAMA5
> +	bool "Atmel Periodic Interval Timer (PIT)"
> +	depends on SOC_AT91SAM9 || SOC_SAMA5
> +	default SOC_AT91SAM9 || SOC_SAMA5
> +	help
> +	  Select this to get a clocksource based on the Atmel Periodic Interval
> +	  Timer. It has a relatively low resolution and the TC Block clocksource
> +	  should be preferred.
> +	  It also provides a clock event device.

Please conform to the format:

config ATMEL_PIT
	bool "Atmel Periodic Interval Timer (PIT)" if COMPILE_TEST
	select ...
	help
	    bla bla

and select ATMEL_PIT from the platform's Kconfig.


>  config ATMEL_ST
>  	bool "Atmel ST timer support" if COMPILE_TEST
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog