linux-kernel - Re: [PATCH 1/3] regcache: flat: Use cache element type in sizeof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180108115914.GC11698@sirena.org.uk>
Date:   Mon, 8 Jan 2018 11:59:14 +0000
From:   Mark Brown <broonie@...nel.org>
To:     "Andrew F. Davis" <afd@...com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] regcache: flat: Use cache element type in sizeof

On Sun, Jan 07, 2018 at 05:22:32PM -0600, Andrew F. Davis wrote:
> A single cache element may not always be unsigned int, use a
> cache element in sizeof over hard-coding its type.

A cache element is *always* unsigned int.  What you mean to say here is
that this helps if in future someone changes the code to use a different
type, it's not fixing a memory corruption problem that exists now which
is what your commit message suggests.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)