linux-kernel - Re: [PATCH 11/45] drivers: misc: remove duplicate includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1219369fe11899a60787d2bf378c2c26@linux.vnet.ibm.com>
Date:   Mon, 08 Jan 2018 14:02:04 +0100
From:   haver <haver@...ux.vnet.ibm.com>
To:     Pravin Shedge <pravin.shedge4linux@...il.com>
Cc:     gpiccoli@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/45] drivers: misc: remove duplicate includes

Hi Pravin,

On 2017-12-06 17:54, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl 
> but
> they have been removed manually to avoid removing false positives.
> 
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@...il.com>
> ---
>  drivers/misc/genwqe/card_base.c  | 1 -
>  drivers/misc/genwqe/card_ddcb.c  | 1 -
>  drivers/misc/genwqe/card_utils.c | 2 --
>  3 files changed, 4 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_base.c 
> b/drivers/misc/genwqe/card_base.c
> index 4fd21e8..42bad26 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -34,7 +34,6 @@
>  #include <linux/wait.h>
>  #include <linux/delay.h>
>  #include <linux/dma-mapping.h>
> -#include <linux/module.h>
>  #include <linux/notifier.h>
>  #include <linux/device.h>
>  #include <linux/log2.h>
> diff --git a/drivers/misc/genwqe/card_ddcb.c 
> b/drivers/misc/genwqe/card_ddcb.c
> index ddfeefe..332a0d1 100644
> --- a/drivers/misc/genwqe/card_ddcb.c
> +++ b/drivers/misc/genwqe/card_ddcb.c
> @@ -34,7 +34,6 @@
>  #include <linux/string.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/delay.h>
> -#include <linux/module.h>
>  #include <linux/interrupt.h>
>  #include <linux/crc-itu-t.h>
> 
> diff --git a/drivers/misc/genwqe/card_utils.c 
> b/drivers/misc/genwqe/card_utils.c
> index 5c0d917..8fec04d 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -32,11 +32,9 @@
>  #include <linux/iommu.h>
>  #include <linux/delay.h>
>  #include <linux/pci.h>
> -#include <linux/dma-mapping.h>
>  #include <linux/ctype.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> -#include <linux/delay.h>
>  #include <asm/pgtable.h>
> 
>  #include "genwqe_driver.h"

Looks ok to me. Thanks for the contribution.

Regards

Frank

Acked-by: Frank Haverkamp <haver@...ux.vnet.ibm.com>