linux-kernel - Re: [RFC PATCH v2] workqueue: Introduce a way to set percpu worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180108142906.GR3668920@devbig577.frc2.facebook.com>
Date:   Mon, 8 Jan 2018 06:29:06 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Wen Yang <wen.yang99@....com.cn>
Cc:     jiangshanlai@...il.com, linux-kernel@...r.kernel.org,
        jiang.biao2@....com.cn, zhong.weidong@....com.cn,
        xiaolong.ye@...el.com, Liu Wei <liu.wei8186@....com.cn>
Subject: Re: [RFC PATCH v2] workqueue: Introduce a way to set percpu
 worker_pool's scheduler

Hello,

On Wed, Dec 27, 2017 at 10:55:41AM +0800, Wen Yang wrote:
> @@ -144,6 +145,11 @@ struct workqueue_attrs {
>  	 * doesn't participate in pool hash calculations or equality comparisons.
>  	 */
>  	bool no_numa;
> +
> +	/**
> +	 * @sched_attr: set kworker's scheduler
> +	 */
> +	struct sched_attr sched_attr;
>  };

It's added as a part of workqueue_attrs but implemented separately.
Can you please do the following instead?

* Add scheduler type to wq_attrs so that unbound workqueues can be
  configured.  Also, we don't need both prio and nice, right?

* Rename system_wq's wq->name from "events" to "system_percpu", and
  similarly for the similarly named workqueues.

* Enable wq_attrs (only the applicable part should show up in the
  interface) for system_percpu and system_percpu_highpri, and use that
  to change the attributes of the percpu pools.

Thanks.

-- 
tejun