| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20180108144854.GE25476@kernel.org>
Date: Mon, 8 Jan 2018 11:48:54 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Jin Yao <yao.jin@...ux.intel.com>
Cc: jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v7 5/6] perf report: support time percent and multiple
time ranges
Em Mon, Jan 08, 2018 at 11:45:06AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Dec 08, 2017 at 09:13:45PM +0800, Jin Yao escreveu:
> > perf report has a --time option to limit the time range of output.
> > It only supports absolute time.
> >
> > Now this option is extended to support multiple time ranges and
> > support the percent of time.
>
> So you're doing two things here, and the error message should be
> improved, telling the user what is to be done to be able to use
> something it is asking for.
>
> I'm trying to split it here...
Nah, I'll leave it as is, but please try to add just one feature per
patch, this way the reviewer can make progress by picking patches he/she
agrees should be merged while leaving parts to be further developed.
Please consider sending a follow up patch improving the error message, I
mean this part:
+ if (perf_time__parse_str(report.ptime_range, report.time_str) != 0) {
+ if (session->evlist->first_sample_time == 0 &&
+ session->evlist->last_sample_time == 0) {
+ pr_err("No first/last sample time in perf data\n");
+ return -EINVAL;
+ }
Add something like:
"HINT: use 'perf record --foobar' to record the first/last sample
timestamps in the perf.data file header or enable build-id processing."
> - Arnaldo
>
> > For example:
> >
> > 1. Select the first and second 10% time slices
> > perf report --time 10%/1,10%/2
> >
> > 2. Select from 0% to 10% and 30% to 40% slices
> > perf report --time 0%-10%,30%-40%
> >
> > Change log:
> > -----------
> > v6: Fix the merge issue with latest perf/core branch.
> > No functional changes.
> >
> > v5: Add checking of first/last sample time to detect if it's recorded
> > in perf.data. If it's not recorded, returns error message to user.
> >
> > v4: Remove perf_time__skip_sample, only uses perf_time__ranges_skip_sample
> >
> > v3: Since the definitions of first_sample_time/last_sample_time
> > are moved from perf_session to perf_evlist so change the
> > related code.
> >
> > Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
> > ---
> > tools/perf/Documentation/perf-report.txt | 16 ++++++++++++++++
> > tools/perf/builtin-report.c | 31 ++++++++++++++++++++++++++-----
> > 2 files changed, 42 insertions(+), 5 deletions(-)
> >
> > diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> > index ddde2b5..ed36553 100644
> > --- a/tools/perf/Documentation/perf-report.txt
> > +++ b/tools/perf/Documentation/perf-report.txt
> > @@ -402,6 +402,22 @@ OPTIONS
> > stop time is not given (i.e, time string is 'x.y,') then analysis goes
> > to end of file.
> >
> > + Also support time percent with multipe time range. Time string is
> > + 'a%/n,b%/m,...' or 'a%-b%,c%-%d,...'. The maximum number of slices is 10.
> > +
> > + For example:
> > + Select the second 10% time slice
> > + perf report --time 10%/2
> > +
> > + Select from 0% to 10% time slice
> > + perf report --time 0%-10%
> > +
> > + Select the first and second 10% time slices
> > + perf report --time 10%/1,10%/2
> > +
> > + Select from 0% to 10% and 30% to 40% slices
> > + perf report --time 0%-10%,30%-40%
> > +
> > --itrace::
> > Options for decoding instruction tracing data. The options are:
> >
> > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > index eb9ce63..946f146 100644
> > --- a/tools/perf/builtin-report.c
> > +++ b/tools/perf/builtin-report.c
> > @@ -52,6 +52,8 @@
> > #include <sys/stat.h>
> > #include <unistd.h>
> >
> > +#define PTIME_RANGE_MAX 10
> > +
> > struct report {
> > struct perf_tool tool;
> > struct perf_session *session;
> > @@ -69,7 +71,8 @@ struct report {
> > const char *cpu_list;
> > const char *symbol_filter_str;
> > const char *time_str;
> > - struct perf_time_interval ptime;
> > + struct perf_time_interval ptime_range[PTIME_RANGE_MAX];
> > + int range_num;
> > float min_percent;
> > u64 nr_entries;
> > u64 queue_size;
> > @@ -186,8 +189,10 @@ static int process_sample_event(struct perf_tool *tool,
> > };
> > int ret = 0;
> >
> > - if (perf_time__skip_sample(&rep->ptime, sample->time))
> > + if (perf_time__ranges_skip_sample(rep->ptime_range, rep->range_num,
> > + sample->time)) {
> > return 0;
> > + }
> >
> > if (machine__resolve(machine, &al, sample) < 0) {
> > pr_debug("problem processing %d event, skipping it.\n",
> > @@ -1077,9 +1082,25 @@ int cmd_report(int argc, const char **argv)
> > if (symbol__init(&session->header.env) < 0)
> > goto error;
> >
> > - if (perf_time__parse_str(&report.ptime, report.time_str) != 0) {
> > - pr_err("Invalid time string\n");
> > - return -EINVAL;
> > + if (perf_time__parse_str(report.ptime_range, report.time_str) != 0) {
> > + if (session->evlist->first_sample_time == 0 &&
> > + session->evlist->last_sample_time == 0) {
> > + pr_err("No first/last sample time in perf data\n");
> > + return -EINVAL;
> > + }
> > +
> > + report.range_num = perf_time__percent_parse_str(
> > + report.ptime_range, PTIME_RANGE_MAX,
> > + report.time_str,
> > + session->evlist->first_sample_time,
> > + session->evlist->last_sample_time);
> > +
> > + if (report.range_num < 0) {
> > + pr_err("Invalid time string\n");
> > + return -EINVAL;
> > + }
> > + } else {
> > + report.range_num = 1;
> > }
> >
> > sort__setup_elide(stdout);
> > --
> > 2.7.4
Powered by blists - more mailing lists