linux-kernel - Re: [PATCH] staging: ccree: ssi_hash: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180108150753.GA22928@kroah.com>
Date:   Mon, 8 Jan 2018 16:07:53 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Elad Wexler <elad.wexler@...il.com>
Cc:     gilad@...yossef.com, devel@...verdev.osuosl.org,
        driverdev-devel@...uxdriverproject.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ccree: ssi_hash: remove unnecessary parentheses

On Thu, Dec 28, 2017 at 12:24:17PM +0200, Elad Wexler wrote:
> Fixed a coding style issue
> 
> Signed-off-by: Elad Wexler <elad.wexler@...il.com>
> ---
>  drivers/staging/ccree/ssi_hash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why did you send this twice?

> diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c
> index 2035835..8d56fa7 100644
> --- a/drivers/staging/ccree/ssi_hash.c
> +++ b/drivers/staging/ccree/ssi_hash.c
> @@ -2280,8 +2280,8 @@ int ssi_hash_alloc(struct ssi_drvdata *drvdata)
>  				      &hash_handle->hash_list);
>  		}
>  
> -		if ((hw_mode == DRV_CIPHER_XCBC_MAC) ||
> -		    (hw_mode == DRV_CIPHER_CMAC))
> +		if (hw_mode == DRV_CIPHER_XCBC_MAC ||
> +		    hw_mode == DRV_CIPHER_CMAC)

No, now I have to go look up if == or || comes in which order.  Ick,
just leave it as-is please.

thanks,

greg k-h