linux-kernel - Re: [PATCH] media: media-device: use strlcpy() instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180108151013.ess23wiff7slpr7h@valkosipuli.retiisi.org.uk>
Date:   Mon, 8 Jan 2018 17:10:13 +0200
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH] media: media-device: use strlcpy() instead of strncpy()

On Mon, Jan 08, 2018 at 08:40:59PM +0800, Xiongfeng Wang wrote:
> From: Xiongfeng Wang <xiongfeng.wang@...aro.org>
> 
> gcc-8 reports
> 
> drivers/media/media-device.c: In function 'media_device_get_topology':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 64 equals destination size [-Wstringop-truncation]
> 
> We need to use strlcpy() to make sure the dest string is nul-terminated.
> 
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@...aro.org>

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi