linux-kernel - Re: [PATCH 01/12] perf tools: Enable LIBBABELTRACE by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180108152433.GK25476@kernel.org>
Date:   Mon, 8 Jan 2018 12:24:33 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCH 01/12] perf tools: Enable LIBBABELTRACE by default

Em Mon, Jan 08, 2018 at 12:20:37PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Jan 08, 2018 at 12:17:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Sun, Jan 07, 2018 at 05:03:45PM +0100, Jiri Olsa escreveu:
> > > There's no reason anymore to treat babel trace in a special way,
> > > because a) we no longer display its state b) the needed babeltrace
> > > library is now out and well adopted among distros.
> > 
> > Humm, after I applied this I got:
> > 
> > [acme@...et perf]$ perf
> > perf: error while loading shared libraries: libbabeltrace-ctf.so.2: cannot open shared object file: No such file or directory
> > [acme@...et perf]$
> > 
> > So it detects it somehow, builds with it, then fails to find it in the
> > LD_LIBRARY_PATH somehow?
> 
> [acme@...et perf]$ ldd ~/bin/perf | grep babel
> 	libbabeltrace-ctf.so.2 => not found
> [acme@...et perf]$
> 
> [acme@...et perf]$ tail -5 /tmp/build/perf/feature/test-libbabeltrace.d 
>  /usr/local/include/babeltrace/ctf-ir/visitor.h \
>  /usr/local/include/babeltrace/values.h \
>  /usr/local/include/babeltrace/ref.h \
>  /usr/local/include/babeltrace/graph/notification.h \
>  /usr/local/include/babeltrace/ctf-ir/stream-class.h
> [acme@...et perf]$
> 
> so I don't have it in LD_LIBRARY_PATH:
> 
> [acme@...et perf]$ export LD_LIBRARY_PATH=/usr/local/lib/
> [acme@...et perf]$ ldd ~/bin/perf | grep babel
> 	libbabeltrace-ctf.so.2 => /usr/local/lib/libbabeltrace-ctf.so.2 (0x00007f6322e83000)
> [acme@...et perf]$ perf stat -e cycles sleep 1
> 
>  Performance counter stats for 'sleep 1':
> 
>            384,636      cycles:u                                                    
> 
>        1.001294682 seconds time elapsed
> 
> [acme@...et perf]$ 
> 
> Will try removing this local install and use what is in fedora27
> instead...

Works:

[acme@...et perf]$ ldd ~/bin/perf | grep babel
	libbabeltrace-ctf.so.1 => /lib64/libbabeltrace-ctf.so.1 (0x00007fcb688d0000)
	libbabeltrace.so.1 => /lib64/libbabeltrace.so.1 (0x00007fcb67e92000)
[acme@...et perf]$ rpm -q libbabeltrace-devel
libbabeltrace-devel-1.5.3-1.fc27.x86_64
[acme@...et perf]$

But then, if we show:

Auto-detecting system features:
...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ on  ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                      libslang: [ on  ]
...                     libcrypto: [ on  ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]

Shoudln't we tell the user that babeltrace was linked too?

- Arnaldo