linux-kernel - Re: [PATCH] Staging: vt6656: fix unnecessary parantheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180108154424.GA12786@kroah.com>
Date:   Mon, 8 Jan 2018 16:44:24 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sumit Pundir <pundirsumit11@...il.com>
Cc:     forest@...ttletooquiet.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: vt6656: fix unnecessary parantheses

On Fri, Dec 22, 2017 at 07:53:52PM +0530, Sumit Pundir wrote:
> This patch fixes a coding style issue as noted by
> checkpatch.pl related to unnecessary parentheses.
> 
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: Unnecessary parentheses around 'priv->basic_rates'.
> 
> Signed-off-by: Sumit Pundir <pundirsumit11@...il.com>
> ---
>  drivers/staging/vt6656/card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index 501f482..811602e 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -443,7 +443,7 @@ int vnt_ofdm_min_rate(struct vnt_private *priv)
>  	int ii;
> 
>  	for (ii = RATE_54M; ii >= RATE_6M; ii--) {
> -		if ((priv->basic_rates) & ((u16)BIT(ii)))
> +		if (priv->basic_rates & ((u16)BIT(ii)))

You still have one too many () around the BIT stuff...