linux-kernel - Re: stable-rc/linux-4.4.y build: 178 builds: 7 failed, 171 passed, 8 errors (v4.4.110-23-g49278737d445)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180108173650.b6ip2yaycr47feib@gmail.com>
Date:   Mon, 8 Jan 2018 18:36:50 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Borislav Petkov <bp@...e.de>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "kernelci.org bot" <bot@...nelci.org>,
        Kernel Build Reports Mailman List 
        <kernel-build-reports@...ts.linaro.org>,
        Hugh Dickins <hughd@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>,
        "4.4.x" <stable@...r.kernel.org>
Subject: Re: stable-rc/linux-4.4.y build: 178 builds: 7 failed, 171 passed, 8
 errors (v4.4.110-23-g49278737d445)


* Borislav Petkov <bp@...e.de> wrote:

> On Mon, Jan 08, 2018 at 03:43:11PM +0100, Arnd Bergmann wrote:
> > This comes from 0cbf2b590bea ("Map the vsyscall page with _PAGE_USER")
> > which adds a line 'bool vsyscall_enabled(void) { return false; }' that
> > presumably
> > should have been 'static inline'.
> 
> Yeah, thanks Arnd.
> 
> @Greg, please fold this in:
> 
> ---
> diff --git a/arch/x86/include/asm/vsyscall.h b/arch/x86/include/asm/vsyscall.h
> index d10cabb..4865e10 100644
> --- a/arch/x86/include/asm/vsyscall.h
> +++ b/arch/x86/include/asm/vsyscall.h
> @@ -19,7 +19,7 @@ static inline bool emulate_vsyscall(struct pt_regs *regs, unsigned long address)
>  {
>  	return false;
>  }
> -bool vsyscall_enabled(void) { return false; }
> +static inline bool vsyscall_enabled(void) { return false; }

Hm, which are the underlying upstream commits - am I missing something?

Thanks,

	Ingo