linux-kernel - Re: [GIT PULL] cgroup fixes for v4.15-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180108192801.GZ3668920@devbig577.frc2.facebook.com>
Date:   Mon, 8 Jan 2018 11:28:01 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Li Zefan <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        cgroups <cgroups@...r.kernel.org>
Subject: Re: [GIT PULL] cgroup fixes for v4.15-rc7

On Mon, Jan 08, 2018 at 11:23:03AM -0800, Linus Torvalds wrote:
> On Mon, Jan 8, 2018 at 11:20 AM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> >
> > Use "strscpy()", which got this _right_.
> 
> Oh Christ.
> 
> It actually did that initially. And then it was changed to the broken
> code due to some idiotic broken warning by tools that don't do the
> right thing.

Dang, I was reading the different str*cpy() functions and suggested
strscpy() and then forgot about it and blindly applied strlcpy()
blindly after the build warning report.  It'd be great to weed out the
useless ones.  These are places where truncation is fine.  Would the
right thing to do be adding (void) in front, which is kinda ugly?

Thanks.

-- 
tejun