linux-kernel - Re: cgroups(7): documenting /sys/kernel/cgroup files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Jan 2018 19:52:39 +0100
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:     Roman Gushchin <guro@...com>
Cc:     mtk.manpages@...il.com, "Serge E. Hallyn" <serge@...lyn.com>,
        Tejun Heo <tj@...nel.org>,
        linux-man <linux-man@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, cgroups@...r.kernel.org
Subject: Re: cgroups(7): documenting /sys/kernel/cgroup files

Hello ROman,

On 01/09/2018 12:28 PM, Roman Gushchin wrote:
> Hello, Michael!
> 
> Overall looks good to me, one small nit below.
> 
> On Mon, Jan 08, 2018 at 10:11:43PM +0100, Michael Kerrisk (man-pages) wrote:
>> Hello Roman,
>>
>> I wrote cgroups(7) text below to document the files added by you in
>> Linux 4.15. Could you let me know if the following text is okay please:
>>
>>    /sys/kernel/cgroup files
>>        /sys/kernel/cgroup/delegate (since Linux 4.15)
>>               This file exports a list of the cgroups v2 files  (one  per
>>               line) that are delegatable (i.e., whose ownership should be
>>               changed to the user ID of the delegatee).  In  the  future,
>>               the  set  of delegatable files may change or grow, and this
>>               file provides a way for the  kernel  to  inform  user-space
>>               applications of which files must be delegated.  As at Linux
>>               4.15, one sees the following when inspecting this file:
>>
>>                   $ cat /sys/kernel/cgroup/delegate
>>                   cgroup.procs
>>                   cgroup.subtree_control
>>
>>        /sys/kernel/cgroup/features (since Linux 4.15)
>>               Over time, the set of cgroups v2 features that are provided
>>               by  the kernel may change or grow, or some features may not
>>               be enabled by default.  This file provides a way for  user-
>>               space  applications  to  discover what features the running
>>               kernel supports or has enabled.  Features  are  listed  one
>                                 ^^
> I would replace "or" with "and" here.

Yes. Done.

> Please, feel free to add
> Reviewed-by: Roman Gushchin <guro@...com>
Thanks!

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/