linux-kernel - Re: [PATCH] staging: pi433: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1515525697.9619.100.camel@perches.com>
Date:   Tue, 09 Jan 2018 11:21:37 -0800
From:   Joe Perches <joe@...ches.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Valentin Vidic <Valentin.Vidic@...Net.hr>,
        David Miller <davem@...emloft.net>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Marcin Ciupak <marcin.s.ciupak@...il.com>,
        Marcus Wolf <linux@...f-entwicklungen.de>,
        Simon Sandström <simon@...anor.nu>
Subject: Re: [PATCH] staging: pi433: remove unnecessary parentheses

On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote:
> > Fixes checkpatch warnings:
> >   CHECK: Unnecessary parentheses around 'mantisse != mantisse16'
> >   CHECK: Unnecessary parentheses around 'mantisse != mantisse20'
> >   CHECK: Unnecessary parentheses around 'mantisse != mantisse24'
[]
> > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
[]
> > @@ -391,9 +391,9 @@ static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg,
> >  		return -EINVAL;
> >  	}
> >  
> > -	if ((mantisse != mantisse16) &&
> > -	    (mantisse != mantisse20) &&
> > -	    (mantisse != mantisse24)) {
> > +	if (mantisse != mantisse16 &&
> > +	    mantisse != mantisse20 &&
> > +	    mantisse != mantisse24) {
> 
> I'm getting really tired of seeing this checkpatch warning, when it's a
> major pain.

Your idea of major pain and mine differ a bit.

> Joe, can you please turn these off.  Patches like this will force people
> to have to remember that != is higher precidence than &&.

As it's not just 1 precedence level but 4 and 5, it
really shouldn't be that hard to remember.

> The original code here was just fine.

And I don't really disagree with you.

David Miller has a preference for the parenthesis free
style. I believe he mentioned it sometime in August 2017
but I can't find it right now.

Anyway, perhaps
---
 scripts/checkpatch.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d2464058ab5d..3a7499de2c2d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4526,7 +4526,9 @@ sub process {
 		}
 
 # check for unnecessary parentheses around comparisons in if uses
-		if ($^V && $^V ge 5.10.0 && defined($stat) &&
+# when !drivers/staging or the command-line uses --strict
+		if (($realfile !~ m@^(?:drivers/staging/)@ || $check_orig) &&
+		    $^V && $^V ge 5.10.0 && defined($stat) &&
 		    $stat =~ /(^.\s*if\s*($balanced_parens))/) {
 			my $if_stat = $1;
 			my $test = substr($2, 1, -1);